summaryrefslogtreecommitdiff
path: root/view/kernelcache
diff options
context:
space:
mode:
Diffstat (limited to 'view/kernelcache')
-rw-r--r--view/kernelcache/core/KernelCache.cpp2
-rw-r--r--view/kernelcache/core/KernelCacheView.cpp2
-rw-r--r--view/kernelcache/core/KernelCacheView.h2
-rw-r--r--view/kernelcache/core/MachO.cpp6
4 files changed, 5 insertions, 7 deletions
diff --git a/view/kernelcache/core/KernelCache.cpp b/view/kernelcache/core/KernelCache.cpp
index ef5fd8a5..6ff88ad1 100644
--- a/view/kernelcache/core/KernelCache.cpp
+++ b/view/kernelcache/core/KernelCache.cpp
@@ -305,7 +305,7 @@ void KernelCache::ProcessRelocations(Ref<BinaryView> view, linkedit_data_command
if (!bind)
{
- uint64_t entryOffset;
+ uint64_t entryOffset = 0;
switch (starts.pointer_format)
{
case DYLD_CHAINED_PTR_ARM64E:
diff --git a/view/kernelcache/core/KernelCacheView.cpp b/view/kernelcache/core/KernelCacheView.cpp
index 8e942268..82f3ce7f 100644
--- a/view/kernelcache/core/KernelCacheView.cpp
+++ b/view/kernelcache/core/KernelCacheView.cpp
@@ -9,7 +9,7 @@
using namespace BinaryNinja;
using namespace BinaryNinja::KC;
-[[maybe_unused]] KernelCacheViewType* g_kcViewType;
+static KernelCacheViewType* g_kcViewType;
KernelCacheViewType::KernelCacheViewType() : BinaryViewType(KC_VIEW_NAME, KC_VIEW_NAME) {}
diff --git a/view/kernelcache/core/KernelCacheView.h b/view/kernelcache/core/KernelCacheView.h
index 9a2baf6f..bfe12502 100644
--- a/view/kernelcache/core/KernelCacheView.h
+++ b/view/kernelcache/core/KernelCacheView.h
@@ -7,8 +7,6 @@
#include <binaryninjaapi.h>
-static const char* VIEW_METADATA_KEY = "shared_cache_view";
-
class KernelCacheView : public BinaryNinja::BinaryView
{
bool m_parseOnly;
diff --git a/view/kernelcache/core/MachO.cpp b/view/kernelcache/core/MachO.cpp
index 9eabf086..01b5da74 100644
--- a/view/kernelcache/core/MachO.cpp
+++ b/view/kernelcache/core/MachO.cpp
@@ -483,9 +483,9 @@ std::vector<CacheSymbol> KernelCacheMachOHeader::ReadSymbolTable(Ref<BinaryView>
if (nlist.n_strx >= stringInfo.entries)
{
// TODO: where logger?
- LogError(
- "Symbol entry at index %llu has a string offset of %u which is outside the strings buffer of size %llu "
- "for symbol table %x",
+ LogErrorF(
+ "Symbol entry at index {} has a string offset of {} which is outside the strings buffer of size {} "
+ "for symbol table {:#x}",
entryIndex, nlist.n_strx, stringInfo.address, stringInfo.entries);
continue;
}