1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
|
use binaryninja::architecture::{Architecture, CoreArchitecture, Flag, Register, RegisterInfo};
use binaryninja::binaryview::{BinaryView, BinaryViewExt};
use binaryninja::command;
use binaryninja::function::Function;
use binaryninja::llil;
use binaryninja::llil::{
Expression, Finalized, Instruction, LiftedNonSSA, NonSSA, ValueExpr, VisitorAction,
};
fn check_expression(expr: &Expression<CoreArchitecture, Finalized, NonSSA<LiftedNonSSA>, ValueExpr>,
required_size: Option<usize>)
{
use llil::ExprInfo::*;
match expr.info() {
Reg(ref op) => {
let size = op.size();
if let Some(required_size) = required_size {
if required_size != size {
error!("LLIL_REG op gives a {} byte value where {} bytes are expected! (addr: {:x} {:?})",
size, required_size, op.address(), expr);
}
}
if let llil::Register::ArchReg(r) = op.source_reg() {
let reg_size = r.info().size();
if reg_size != size {
error!("LLIL_REG attempting to load {} bytes out of a {} byte register! (addr: {:x} {:?})",
size, reg_size, op.address(), expr);
}
}
}
Flag(ref op) => {
if let Some(required_size) = required_size {
if required_size != 0 {
error!("LLIL_FLAG op gives a boolean value where {} bytes are expected! (addr: {:x} {:?})",
required_size, op.address(), expr);
}
}
}
FlagBit(ref op) => {
// TODO
}
Load(ref op) => {
if let Some(required_size) = required_size {
if required_size != op.size() {
error!("LLIL_LOAD op gives a {} byte value where {} bytes are expected! (addr: {:x} {:?})",
op.size(), required_size, op.address(), expr);
}
}
}
Pop(ref op) => {
if let Some(required_size) = required_size {
if required_size != op.size() {
error!("LLIL_POP op gives a {} byte value where {} bytes are expected! (addr: {:x} {:?})",
op.size(), required_size, op.address(), expr);
}
}
}
Const(ref op) | ConstPtr(ref op) => {
if let Some(required_size) = required_size {
if required_size != op.size() {
error!("LLIL_CONST op gives a {} byte value where {} bytes are expected! (addr: {:x} {:?})",
op.size(), required_size, op.address(), expr);
}
}
}
FlagCond(ref op) => {
if let Some(required_size) = required_size {
if required_size != 0 {
error!("LLIL_FLAG_COND op gives boolean value where {} bytes are expected! (addr: {:x} {:?})",
required_size, op.address(), expr);
}
}
}
CmpE(ref op) | CmpNe(ref op) |
CmpSlt(ref op) | CmpUlt(ref op) |
CmpSle(ref op) | CmpUle(ref op) |
CmpSge(ref op) | CmpUge(ref op) |
CmpSgt(ref op) | CmpUgt(ref op) => {
if let Some(required_size) = required_size {
if required_size != 0 {
error!("LLIL_CMP ops produce a boolean value, and a {} byte value is expected here! (addr: {:x} {:?})",
required_size, op.address(), expr);
}
}
let cmp_size = op.size();
if cmp_size == 0 {
error!("compare of zero width detected! {:?}", expr);
}
check_expression(&op.left(), Some(cmp_size));
check_expression(&op.right(), Some(cmp_size));
}
Adc(ref op) |
Sbb(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL_ADC/SBB producing {} byte value {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
check_expression(&op.left(), Some(op_size));
check_expression(&op.right(), Some(op_size));
check_expression(&op.carry(), Some(0));
}
Rlc(ref op) |
Rrc(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL_RLC/RRC producing {} byte value {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
// rotate amounts just need to be >= 1 byte
if let Some(0) = op.right().info().size() {
error!("LLIL_RLC/RRC can't rotate by a 0 byte expression! (addr: {:x} {:?})",
op.address(), expr);
}
check_expression(&op.left(), Some(op_size));
check_expression(&op.right(), None);
check_expression(&op.carry(), Some(0));
}
Add(ref op) |
Sub(ref op) |
And(ref op) |
Or (ref op) |
Xor(ref op) |
Mul(ref op) |
Divu(ref op) |
Divs(ref op) |
Modu(ref op) |
Mods(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL binary op producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
check_expression(&op.left(), Some(op_size));
check_expression(&op.right(), Some(op_size));
}
Lsl(ref op) |
Lsr(ref op) |
Asr(ref op) |
Rol(ref op) |
Ror(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL rotate/shift binary op producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
// rotate amounts just need to be >= 1 byte
if let Some(0) = op.right().info().size() {
error!("LLIL shift/rotate ops can't rotate by a 0 byte expression! (addr: {:x} {:?})",
op.address(), expr);
}
check_expression(&op.left(), Some(op_size));
check_expression(&op.right(), None);
}
MulsDp(ref op) |
MuluDp(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size * 2 {
error!("LLIL double precision mul op producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
check_expression(&op.left(), Some(op_size));
check_expression(&op.right(), Some(op_size));
}
DivuDp(ref op) |
DivsDp(ref op) |
ModuDp(ref op) |
ModsDp(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL double precision div op producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
// TODO what's the actual right size here?
check_expression(&op.high(), Some(op_size));
check_expression(&op.low(), Some(op_size));
check_expression(&op.right(), Some(op_size));
}
Neg(ref op) |
Not(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL unary op producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
check_expression(&op.operand(), Some(op_size));
}
Sx(ref op) |
Zx(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL extending op producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
let operand = op.operand();
if let Some(actual_size) = operand.info().size() {
if actual_size >= op_size {
error!("LLIL extending op to {} bytes is invalid; source is already {} bytes (addr: {:x} {:?})",
op_size, actual_size, op.address(), expr);
}
}
check_expression(&operand, None);
}
LowPart(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL_LOW_PART truncating to {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
let operand = op.operand();
if let Some(actual_size) = operand.info().size() {
if actual_size <= op_size {
error!("LLIL truncating op to {} bytes is invalid; source is already {} bytes (addr: {:x} {:?})",
op_size, actual_size, op.address(), expr);
}
}
check_expression(&operand, None);
}
BoolToInt(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL_BOOL_TO_INT extending to {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
check_expression(&op.operand(), Some(0));
}
UnimplMem(ref op) => {
let op_size = op.size();
if let Some(required_size) = required_size {
if required_size != op_size {
error!("LLIL_UNIMPL_MEM producing {} byte value where {} byte value is expected! (addr: {:x} {:?})",
op_size, required_size, op.address(), expr);
}
}
check_expression(&op.mem_expr(), None);
}
Unimpl(_) => {}
op => {
info!(" unhandled expr @ {:x} ... {:?}", op.address(), expr);
}
}
}
fn check_instruction(inst: &Instruction<CoreArchitecture, Finalized, NonSSA<LiftedNonSSA>>) {
use llil::InstrInfo::*;
match inst.info() {
SetReg(op) => {
let required_expr_size = op.size();
// TODO how to do sanity checking for temp registers?
if let llil::Register::ArchReg(r) = op.dest_reg() {
let reg_size = r.info().size();
if reg_size != required_expr_size {
error!("LLIL_SET_REG can't set {} byte register to {} byte value! (addr: {:x})",
reg_size, required_expr_size, op.address());
}
}
check_expression(&op.source_expr(), Some(required_expr_size));
}
SetRegSplit(op) => {
let required_reg_size = op.size();
if let llil::Register::ArchReg(hi) = op.dest_reg_high() {
if hi.info().size() != required_reg_size {
error!("LLIL_SET_REG_SPLIT received a register with wrong size (wanted {} bytes)! (addr: {:x})",
required_reg_size, op.address());
}
}
if let llil::Register::ArchReg(lo) = op.dest_reg_low() {
if lo.info().size() != required_reg_size {
error!("LLIL_SET_REG_SPLIT received a register with wrong size (wanted {} bytes)! (addr: {:x})",
required_reg_size, op.address());
}
}
check_expression(&op.source_expr(), Some(required_reg_size * 2));
}
SetFlag(op) => {
check_expression(&op.source_expr(), Some(0));
}
Store(op) => {
let required_expr_size = op.size();
if required_expr_size == 0 {
error!("LLIL_STORE storing a 0 byte value! non-sensical! (addr {:x})", op.address());
}
// TODO make sure size matches arch default addr len?
check_expression(&op.dest_mem_expr(), None);
check_expression(&op.source_expr(), Some(required_expr_size));
}
Push(op) => {
let required_expr_size = op.size();
if required_expr_size == 0 {
error!("LLIL_PUSH pushing a 0 byte value! non-sensical! (addr {:x})", op.address());
}
check_expression(&op.operand(), Some(required_expr_size));
}
Jump(op) => {
check_expression(&op.target(), None);
}
JumpTo(op) => {
check_expression(&op.target(), None);
}
Call(op) => {
check_expression(&op.target(), None);
}
Ret(op) => {
check_expression(&op.target(), None);
}
If(op) => {
check_expression(&op.condition(), Some(0));
}
Value(e, _) => {
check_expression(&e, None);
}
_ => {},
}
}
pub fn check_function(func: &Function) {
if let Ok(llil) = func.lifted_il() {
for block in &llil.basic_blocks() {
for inst in &*block {
check_instruction(&inst);
}
}
}
}
use rayon::prelude::*;
use std::thread;
use std::time;
pub fn check_all_functions_parallel(bv: &BinaryView) {
let bv = bv.to_owned();
thread::spawn(move || {
let start = time::Instant::now();
let functions = bv.functions();
functions.par_iter().for_each(|f| check_function(&f));
let elapsed = time::Instant::now().duration_since(start);
info!("LiftCheck parallel: checked {} functions in {:?} seconds", functions.len(), elapsed);
});
}
|