summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRusty Wagner <rusty.wagner@gmail.com>2024-10-30 15:21:08 -0400
committerRusty Wagner <rusty.wagner@gmail.com>2024-10-30 17:23:29 -0400
commita54125565bb32bfb8af86f9b3ab3cb2151d76a14 (patch)
tree0483c37de8d644e28b1a1278bd22b84f8b960468
parent85a14f0f1fce79b7bedeb420f32e3af60b2d3a6b (diff)
Fix memory ordering issues found with TSAN
-rw-r--r--ui/featuremap.h2
-rw-r--r--ui/linearview.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/ui/featuremap.h b/ui/featuremap.h
index f17d5981..12b25488 100644
--- a/ui/featuremap.h
+++ b/ui/featuremap.h
@@ -47,7 +47,7 @@ class BINARYNINJAUIAPI FeatureMap : public QWidget, public BinaryNinja::BinaryDa
BinaryViewRef m_data;
std::unique_ptr<NotificationsDispatcher> m_dispatcher = nullptr;
- bool m_updatesPending = false;
+ std::atomic<bool> m_updatesPending = false;
QTimer* m_updateTimer = nullptr;
size_t m_imgWidth = 0;
size_t m_imgHeight = 0;
diff --git a/ui/linearview.h b/ui/linearview.h
index 05700e70..c3e2bce4 100644
--- a/ui/linearview.h
+++ b/ui/linearview.h
@@ -195,7 +195,7 @@ class BINARYNINJAUIAPI LinearView : public QAbstractScrollArea, public View, pub
int m_wheelDelta;
bool m_updatingScrollBar;
- bool m_updatesRequired;
+ std::atomic<bool> m_updatesRequired;
bool m_updateBounds;
LinearViewCursorPosition m_cursorPos, m_selectionStartPos;