diff options
| author | Mark Rowe <mark@vector35.com> | 2025-08-27 21:52:48 -0700 |
|---|---|---|
| committer | Mark Rowe <mark@vector35.com> | 2025-09-02 18:58:49 -0700 |
| commit | 837049b5534bc3dc6cbe83b136e514fd72602e42 (patch) | |
| tree | f3f249d797c402fab401a3354abd27f0cd70f312 /CMakeLists.txt | |
| parent | 82a858d3be86d4e701cf8e2ebdc31c8d70237dd6 (diff) | |
Introduce a new define to control LogTrace rather than using _DEBUG
Defining `_DEBUG` changes which MSVC runtime library needs to be linked
which breaks clients attempting to use the C++ API with `RelWithDebInfo`.
To fix this we define a new private `BN_ENABLE_LOG_TRACE` macro and use
that within log.cpp where it was previously using `_DEBUG`.
Fixes https://github.com/Vector35/binaryninja-api/issues/7288.
Diffstat (limited to 'CMakeLists.txt')
| -rw-r--r-- | CMakeLists.txt | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 3a28b964..197897a6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -63,9 +63,7 @@ if(BN_REF_COUNT_DEBUG) endif() if(CMAKE_BUILD_TYPE MATCHES Debug OR CMAKE_BUILD_TYPE MATCHES RelWithDebInfo) - target_compile_definitions(binaryninjaapi PRIVATE _DEBUG) -else() - target_compile_definitions(binaryninjaapi PRIVATE NDEBUG) + target_compile_definitions(binaryninjaapi PRIVATE BN_ENABLE_LOG_TRACE) endif() add_subdirectory(vendor/fmt EXCLUDE_FROM_ALL) |