summaryrefslogtreecommitdiff
path: root/binaryview.cpp
diff options
context:
space:
mode:
authorBrian Potchik <brian@vector35.com>2019-08-11 23:04:17 -0400
committerBrian Potchik <brian@vector35.com>2019-08-11 23:04:17 -0400
commit02023064fc5e112985035a9c0b3dc0957cdfda02 (patch)
tree9fb0048fd2ecac09311cb4dc153f7a43be03f669 /binaryview.cpp
parent472cbb7a1cb3b51846abd3bda810c5dcc644acd7 (diff)
Eliminate mandatory ephemeral view creation during open with options.
Diffstat (limited to 'binaryview.cpp')
-rw-r--r--binaryview.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/binaryview.cpp b/binaryview.cpp
index e44bca2b..853d42d3 100644
--- a/binaryview.cpp
+++ b/binaryview.cpp
@@ -2994,7 +2994,7 @@ uint64_t BinaryView::GetUIntMetadata(const string& key)
}
-Ref<Settings> BinaryView::GetLoadSettings(string typeName)
+Ref<Settings> BinaryView::GetLoadSettings(const string& typeName)
{
BNSettings* settings = BNBinaryViewGetLoadSettings(m_object, typeName.c_str());
if (!settings)
@@ -3003,7 +3003,7 @@ Ref<Settings> BinaryView::GetLoadSettings(string typeName)
}
-void BinaryView::SetLoadSettings(string typeName, Ref<Settings> settings)
+void BinaryView::SetLoadSettings(const string& typeName, Ref<Settings> settings)
{
BNBinaryViewSetLoadSettings(m_object, typeName.c_str(), settings->GetObject());
}