diff options
| author | Rusty Wagner <rusty.wagner@gmail.com> | 2025-06-24 17:55:48 -0400 |
|---|---|---|
| committer | Alexander Taylor <alex@vector35.com> | 2025-06-25 18:36:47 -0400 |
| commit | c41f264a1dba68c89b4a224a70e3a5783f7fa879 (patch) | |
| tree | 00bb6e91d86b708bff7265ed7179a6ef2793b7fb /defaultabb.cpp | |
| parent | b1a7666164a000c5255f90568ed9597b58ce276a (diff) | |
Remove implicit conversions from Confidence to underlying type, these can cause bugs and also issues with C++20
Diffstat (limited to 'defaultabb.cpp')
| -rw-r--r-- | defaultabb.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/defaultabb.cpp b/defaultabb.cpp index 477e5722..00d0e560 100644 --- a/defaultabb.cpp +++ b/defaultabb.cpp @@ -337,9 +337,9 @@ void Architecture::DefaultAnalyzeBasicBlocks(Function* function, BasicBlockAnaly { // Deal with direct pointers into the extern section DataVariable dataVar; - if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) && - (dataVar.address == info.branchTarget[i]) && dataVar.type && - (dataVar.type->GetClass() == FunctionTypeClass)) + if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) + && (dataVar.address == info.branchTarget[i]) && dataVar.type.GetValue() + && (dataVar.type->GetClass() == FunctionTypeClass)) { directRefs[info.branchTarget[i]].emplace(location); if (!dataVar.type->CanReturn()) @@ -414,9 +414,9 @@ void Architecture::DefaultAnalyzeBasicBlocks(Function* function, BasicBlockAnaly { // Deal with direct pointers into the extern section DataVariable dataVar; - if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) && - (dataVar.address == info.branchTarget[i]) && dataVar.type && - (dataVar.type->GetClass() == FunctionTypeClass)) + if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) + && (dataVar.address == info.branchTarget[i]) && dataVar.type.GetValue() + && (dataVar.type->GetClass() == FunctionTypeClass)) { directRefs[info.branchTarget[i]].emplace(location); if (!dataVar.type->CanReturn()) |