summaryrefslogtreecommitdiff
path: root/plugins
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2024-10-28 21:21:49 -0400
committerMason Reed <mason@vector35.com>2024-10-28 21:21:55 -0400
commit36982c4208d8aaa369211ec2d5f3aad3b2f57ee7 (patch)
treef28654a398393b2503ccd3f544258ea5c74fdaaf /plugins
parent6312db754a479ca07dc67ac7c91ecf9f801cf9b9 (diff)
Fix WARP symbol conversion using the wrong modifiers
Diffstat (limited to 'plugins')
-rw-r--r--plugins/warp/src/convert.rs9
1 files changed, 4 insertions, 5 deletions
diff --git a/plugins/warp/src/convert.rs b/plugins/warp/src/convert.rs
index cbb47858..85a288f4 100644
--- a/plugins/warp/src/convert.rs
+++ b/plugins/warp/src/convert.rs
@@ -53,12 +53,11 @@ pub fn from_bn_symbol(raw_symbol: &BNSymbol) -> Symbol {
BNSymbolType::LocalLabel => {
todo!()
}
- // BN External is our Exported
BNSymbolType::External => Symbol::new(
symbol_name,
- // TODO: Data?
- SymbolClass::Data,
- SymbolModifiers::Exported,
+ // TODO: External data?
+ SymbolClass::Function,
+ SymbolModifiers::External,
),
BNSymbolType::ImportedData => {
Symbol::new(symbol_name, SymbolClass::Data, SymbolModifiers::External)
@@ -68,10 +67,10 @@ pub fn from_bn_symbol(raw_symbol: &BNSymbol) -> Symbol {
SymbolClass::Function,
SymbolModifiers::default(),
),
- // BN Imported is our External
BNSymbolType::ImportedFunction => Symbol::new(
symbol_name,
SymbolClass::Function,
+ // TODO: Exported?
SymbolModifiers::External,
),
}