summaryrefslogtreecommitdiff
path: root/rust/src/platform.rs
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2026-04-21 18:10:51 -0700
committerMason Reed <35282038+emesare@users.noreply.github.com>2026-05-10 17:13:08 -0700
commitc4ba6d79ae3b96d56cc6b3744e7c64e004ecd161 (patch)
tree5762fc3ff58b57caec5f42176faf6635c464b4f3 /rust/src/platform.rs
parent8269a8ac29e59c7949af753dac5c1f36bb700903 (diff)
[Rust] Refactor `binary_view` module
- Remove the "viral" `BinaryViewExt` trait and its blanket impl - Split up the binary view type from the custom trait impl - Simplify and fix bugs regarding custom binary view initialization - Rewrite Minidump binary view example, parses the PE headers to create proper sections now - Add some extra documentation - Add unit test for custom binary view
Diffstat (limited to 'rust/src/platform.rs')
-rw-r--r--rust/src/platform.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/rust/src/platform.rs b/rust/src/platform.rs
index bf135fae..e70e1277 100644
--- a/rust/src/platform.rs
+++ b/rust/src/platform.rs
@@ -176,7 +176,7 @@ impl Platform {
pub fn type_container(&self) -> TypeContainer {
let type_container_ptr = NonNull::new(unsafe { BNGetPlatformTypeContainer(self.handle) });
// NOTE: I have no idea how this isn't a UAF, see the note in `TypeContainer::from_raw`
- // TODO: We are cloning here for platforms but we dont need to do this for [BinaryViewExt::type_container]
+ // TODO: We are cloning here for platforms but we dont need to do this for [BinaryView::type_container]
// TODO: Why does this require that we, construct a TypeContainer, duplicate the type container, then drop the original.
unsafe { TypeContainer::from_raw(type_container_ptr.unwrap()) }
}